Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restore latest filter on app start #477

Closed
wants to merge 1 commit into from
Closed

feat: restore latest filter on app start #477

wants to merge 1 commit into from

Conversation

Bnyro
Copy link
Contributor

@Bnyro Bnyro commented Jul 27, 2023

No description provided.

@krille-chan
Copy link
Owner

Hm, sorry I do not agree that we should make this configurable. This would be too much configuration option IMO. Instead we could just persist the last active filter and reopen the app exactly there when the app gets opened again

@Bnyro
Copy link
Contributor Author

Bnyro commented Jul 28, 2023

I haven't been sure which solution you'd prefer, thus I decided to add it as an option since that's what most other apps do commonly.
However, I do agree with you, remembering the filter is probably the more user convenient solution.
Pushed the changes.

@Bnyro Bnyro changed the title feat: option to set the start/default tab/filter feat: restore latest filter on app start Jul 28, 2023
@krille-chan
Copy link
Owner

Currently this does not work but I think this is the same problem as #614 I will try to solve it

@krille-chan
Copy link
Owner

I have refactored the code base of the Store. Now it should be possible to do it as you have planned it @Bnyro can you update your PR?

@Bnyro
Copy link
Contributor Author

Bnyro commented Nov 6, 2023

I'm not able to build the app currently hence I can't tell if this still works unfortunately.

@basings basings mentioned this pull request Jan 23, 2024
@Henry-Hiles Henry-Hiles mentioned this pull request Feb 7, 2024
@Bnyro Bnyro closed this by deleting the head repository Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants